Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ephemeralca in cosign e2e tests with fileca #301

Closed
nsmith5 opened this issue Dec 29, 2021 · 4 comments · Fixed by #309
Closed

Replace ephemeralca in cosign e2e tests with fileca #301

nsmith5 opened this issue Dec 29, 2021 · 4 comments · Fixed by #309
Labels
enhancement New feature or request

Comments

@nsmith5
Copy link
Contributor

nsmith5 commented Dec 29, 2021

Description

In the fileca PR we dicussed using fileca instead of emphemeralca in e2e tests.
@nsmith5 nsmith5 added the enhancement New feature or request label Dec 29, 2021
@nsmith5
Copy link
Contributor Author

nsmith5 commented Dec 29, 2021

@mattmoor is this still desired? I know there is that API endpoint that returns the CA certifficate chain now and wasn't sure if that covered the same need..

@mattmoor
Copy link
Member

I think we probably do. cc @vaikas for thoughts

@vaikas
Copy link
Contributor

vaikas commented Dec 30, 2021

Yeah, that would make the most sense to me, because indeed we now have a way to programmatically fetch the cert being used. Which led me to questioning the need for ephemeralca in the first place anymore, but that's another discussion :)

@jdolitsky
Copy link
Contributor

Just for reference purposes, the fileca PR mentioned is #280

jdolitsky added a commit to jdolitsky/fulcio that referenced this issue Jan 4, 2022
@jdolitsky
Switch to use fileca in e2e tests
ac07095 
Resolves sigstore#301

Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@jdolitsky jdolitsky mentioned this issue Jan 4, 2022
Merged
jdolitsky added a commit to jdolitsky/fulcio that referenced this issue Jan 5, 2022
@jdolitsky
Switch to use fileca in e2e tests
d6c41a2 
Resolves sigstore#301

Signed-off-by: Josh Dolitsky <josh@dolit.ski>
jdolitsky added a commit to jdolitsky/fulcio that referenced this issue Jan 5, 2022
@jdolitsky
Switch to use fileca in e2e tests
8738de8 
Resolves sigstore#301

Signed-off-by: Josh Dolitsky <josh@dolit.ski>
mattmoor pushed a commit that referenced this issue Jan 7, 2022
@jdolitsky
Switch to use fileca in e2e tests (#309)
71f212c 
Resolves #301

Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to use fileca in e2e tests jdolitsky/fulcio
4 participants
@jdolitsky @mattmoor @vaikas @nsmith5