Add 404 text, restore internationalization folder #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docssigstore ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Changed 404 text. Restyled 404 page Restored internationalization folder deleted while setting up site. This folder is used for i18n of interface elements. By default, the 404 pages and search box refer to the i18n folder for text. Resolves sigstore#236 Signed-off-by: Patrick Smyth <patrick@iotaschool.com>
b52cbf0 to
1a5a812
Compare
ltagliaferri
approved these changes
Aug 24, 2023
normal-coder
added a commit
to normal-coder/Sigstore-Docs
that referenced
this pull request
Aug 25, 2023
* main: ci(github action): add Markdown linter check support for main branch (sigstore#227) Redirects now appears in public (sigstore#234) add 'cosign sign-blob'in the mTLS TSA section (sigstore#239) Changed 404 text, restored i18n (sigstore#238) Restored Netlify redirects file (sigstore#233) Removed docs from URL path (sigstore#232) Corrected the confusion of steps in the document due to formatting (sigstore#220) Added anchor text to link to releases page (sigstore#223)
normal-coder
added a commit
to normal-coder/Sigstore-Docs
that referenced
this pull request
Aug 25, 2023
* main: ci(github action): add Markdown linter check support for main branch (sigstore#227) Redirects now appears in public (sigstore#234) add 'cosign sign-blob'in the mTLS TSA section (sigstore#239) Changed 404 text, restored i18n (sigstore#238) Restored Netlify redirects file (sigstore#233) Removed docs from URL path (sigstore#232) Corrected the confusion of steps in the document due to formatting (sigstore#220) Added anchor text to link to releases page (sigstore#223)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restores the i18n (internationalization) folder that contains text for some interface elements on the site, such as the search box and 404 page. Further, it changes the 404 text and restyles the 404 page slightly.
Context
Currently, the 404 page has no text, which is not ideal. While the site is not a multilingual site, we have current issues open related to making the docs site multilingual and restoring the i18n page would be a good, if minor, first step in that direction. Therefore, I've restored the i18n page rather than hardcoding English into these interface elements.
Notes
Resolves #236
References #131