-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor verifyNewBundle into library function #4013
base: main
Are you sure you want to change the base?
Refactor verifyNewBundle into library function #4013
Conversation
Signed-off-by: Cody Soyland <codysoyland@github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4013 +/- ##
==========================================
- Coverage 40.10% 36.46% -3.65%
==========================================
Files 155 210 +55
Lines 10044 13351 +3307
==========================================
+ Hits 4028 4868 +840
- Misses 5530 7872 +2342
- Partials 486 611 +125 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
@haydentherapper @cmurphy @steiza I would appreciate a look at this whenever you have a moment! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I don't have any further comments other than the things already raised by @malancas.
Signed-off-by: Cody Soyland <codysoyland@github.com>
I will take a look at the conformance failures Monday. Thanks all! |
This var has a default value so shouldn't be checked Signed-off-by: Cody Soyland <codysoyland@github.com>
These tests are incorrect: they set the signature field which is not allowed when doing bundle verification. Previously they were passing due to logic errors. Signed-off-by: Cody Soyland <codysoyland@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Summary
This is a refactor of the bundle verification logic that replaces verifyNewBundle with a re-written library function
cosign.VerifyNewBundle
, which accepts a simplified set of arguments, usingCheckOpts
to supply the majority of the configuration. It has been moved out of thecli
package into thecosign
package and made public.This is partially extracted from #3889.
Release Note
Documentation