Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor verifyNewBundle into library function #4013

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

codysoyland
Copy link
Member

@codysoyland codysoyland commented Jan 14, 2025

Summary

This is a refactor of the bundle verification logic that replaces verifyNewBundle with a re-written library function cosign.VerifyNewBundle, which accepts a simplified set of arguments, using CheckOpts to supply the majority of the configuration. It has been moved out of the cli package into the cosign package and made public.

This is partially extracted from #3889.

Release Note

Documentation

Signed-off-by: Cody Soyland <codysoyland@github.com>
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 48.32536% with 108 lines in your changes missing coverage. Please review.

Project coverage is 36.46%. Comparing base (2ef6022) to head (5932f1f).
Report is 278 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cosign/cli/verify/verify_blob.go 37.07% 46 Missing and 10 partials ⚠️
cmd/cosign/cli/verify/verify_blob_attestation.go 40.38% 26 Missing and 5 partials ⚠️
pkg/cosign/verify.go 74.13% 10 Missing and 5 partials ⚠️
pkg/cosign/verify_bundle.go 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4013      +/-   ##
==========================================
- Coverage   40.10%   36.46%   -3.65%     
==========================================
  Files         155      210      +55     
  Lines       10044    13351    +3307     
==========================================
+ Hits         4028     4868     +840     
- Misses       5530     7872    +2342     
- Partials      486      611     +125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
@codysoyland codysoyland marked this pull request as ready for review January 21, 2025 21:06
@codysoyland codysoyland changed the title [DRAFT] Refactor verifyNewBundle into library function Refactor verifyNewBundle into library function Jan 21, 2025
@codysoyland
Copy link
Member Author

@haydentherapper @cmurphy @steiza I would appreciate a look at this whenever you have a moment!

Copy link
Member

@steiza steiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I don't have any further comments other than the things already raised by @malancas.

Signed-off-by: Cody Soyland <codysoyland@github.com>
@codysoyland
Copy link
Member Author

I will take a look at the conformance failures Monday. Thanks all!

This var has a default value so shouldn't be checked

Signed-off-by: Cody Soyland <codysoyland@github.com>
These tests are incorrect: they set the signature field which is not allowed when doing bundle verification. Previously they were passing due to logic errors.

Signed-off-by: Cody Soyland <codysoyland@github.com>
Copy link

@malancas malancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants