Allow to fetch signatures by signed entity. #3007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Haus <dhaus@redhat.com>
f9f2138 to
12d0241
Compare
Codecov Report
@@ Coverage Diff @@
## main #3007 +/- ##
==========================================
- Coverage 30.23% 30.23% -0.01%
==========================================
Files 151 151
Lines 9478 9480 +2
==========================================
Hits 2866 2866
- Misses 6167 6169 +2
Partials 445 445
|
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was closed because it has been stalled for 10 days with no activity. |
|
Recreated in #4047 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using cosign as a dependency and attempting to fetch signatures for a specific signed entity, the signed entity is always fetched from the registry.
In case the signed entity has been fetched previously, it'd be nice to introduce a function similar to the
FetchAttestationsthat allows to fetch signatures from the signed entity directly, without reaching out to the registry to fetch the signed entity beforehand.With the current changes in the PR, the error will now not include the reference anymore. However, the changes were also made to
FetchAttestationsin the same way.If we want to include this information, we may wrap the returned error from
FetchAttestations/FetchSignatureswith the reference, so the content of the error will stay the same.Release Note
NONE