Add support for importing PKCS#8 private keys, and add validation #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for PKCS#8 encoded private keys, which means we can also import ED25519 keys. I've added tests for PKCS#8 RSA and ECDSA keys too. I also added some validation of keys before importing. For RSA, we will require that the key size be between 2048 and 4096. For ECDSA keys, we will only disallow NIST P-224, since Cosign generates P-256 by default. Other curves are not supported by Go's crypto library. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
cc @venafi-iw |
|
It's up for debate if we want to have an upper bound on the size of the RSA key, but larger than 4096 gets a bit unwieldy, requiring more storage space and some verification libraries can't handle large RSA keys. |
|
This looks awesome! |
dlorenc
approved these changes
Jan 12, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…gstore#1300) This adds support for PKCS#8 encoded private keys, which means we can also import ED25519 keys. I've added tests for PKCS#8 RSA and ECDSA keys too. I also added some validation of keys before importing. For RSA, we will require that the key size be between 2048 and 4096. For ECDSA keys, we will only disallow NIST P-224, since Cosign generates P-256 by default. Other curves are not supported by Go's crypto library. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for PKCS#8 encoded private keys, which means
we can also import ED25519 keys. I've added tests for PKCS#8
RSA and ECDSA keys too.
I also added some validation of keys before importing. For RSA,
we will require that the key size be between 2048 and 4096.
For ECDSA keys, we will only disallow NIST P-224, since Cosign
generates P-256 by default. Other curves are not supported
by Go's crypto library.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Ticket Link
#549
Release Note