level down libp2p quic accept and close errors #6148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
commented
Jul 22, 2024
| } | ||
| None |
There was a problem hiding this comment.
previously we were checking the number of listeners, but it's redundant here as they will only decrease if gracefully closed, ListenerErrors are non fatal and therefore shouldn't close the listener
8824d44 to
09a2acc
Compare
09a2acc to
5ec2ffb
Compare
AgeManning
approved these changes
Jul 23, 2024
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d72dca5 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
After quinn-rs/quinn#1804
quinnnow returns this accept error which is also bubbled bylibp2pas aListenerError, this PR silenceslibp2p-quicaccept errors in general as they are mostly connection refusals.libp2p::quic::Error::Connectionalso covers connection close errors which are also redundant on our case.