Add KZG commitment consistency check #6044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
added a commit
that referenced
this pull request
Jul 12, 2024
Squashed commit of the following: commit 4859e84 Author: Jimmy Chen <jchen.tc@gmail.com> Date: Thu Jul 4 10:38:46 2024 +1000 Check for kzg commitments consistency when adding gossip data columns to `DataAvailabilityChecker`. commit 44ba3c4 Author: Jimmy Chen <jchen.tc@gmail.com> Date: Thu Jul 4 10:06:13 2024 +1000 Check for kzg commitments consistency with block for `RpcBlock`.
dapplion
reviewed
Jul 16, 2024
| for (&column_commitment, &block_commitment) in | ||
| column_commitments.iter().zip(block_commitments.iter()) | ||
| { | ||
| if column_commitment != block_commitment { |
There was a problem hiding this comment.
I actually want to remove this check for blob sidecars since the inclusion proof should ensure that this never happens. Have you observed this inconsistency issue on devnets?
There was a problem hiding this comment.
Yeah I actually ran into a few KZG errors during sync.
I think you raised a good point and this PR shouldn't be required. The proper fix is to ensure that we verify the inclusion proof - I think we're missing this in sampling and by range rpc. I'll raise an issue.
There was a problem hiding this comment.
Raised issue #6111. Closing this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Check data column commitments against block commitments when adding to
DataAvailabilityCheckerand constructing anRpcBlock.