Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bls_to_execution_change topic to eth1/v1/events #5823

Merged
merged 12 commits into from
May 30, 2024
Merged

Add bls_to_execution_change topic to eth1/v1/events #5823

merged 12 commits into from
May 30, 2024

Conversation

chong-he
Copy link
Member

Add bls_to_execution_change topic to the beacon API eth1/v1/events

@dapplion dapplion added the ready-for-review The code is ready for review label May 22, 2024
@michaelsproul
Copy link
Member

We're going to discuss adding tests to this PR later today

@michaelsproul michaelsproul added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels May 23, 2024
@chong-he
Copy link
Member Author

Adding .deterministic_withdrawal_keypairs(VALIDATOR_COUNT) works, thanks so much @michaelsproul

@chong-he chong-he added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels May 27, 2024
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels May 29, 2024
jimmygchen
jimmygchen approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👏

@michaelsproul
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link

mergify bot commented May 30, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at ffe29c0

mergify bot added a commit that referenced this pull request May 30, 2024
@mergify
Merge of #5823
958052d
@mergify mergify bot mentioned this pull request May 30, 2024
Closed
5 tasks
@mergify mergify bot merged commit ffe29c0 into sigp:unstable May 30, 2024
28 checks passed
@chong-he chong-he deleted the BeaconAPI-events branch July 16, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees
No one assigned
Labels
HTTP-API ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chong-he @michaelsproul @jimmygchen @dapplion