-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consensus): add the max_request_blocks
field in ChainSpec
#4800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it looks like this problem is a bit more involved than described on the issue. We not only need to include the max_request_blocks
in the chain spec, but also need to use this value in place of the existing MAX_REQUEST_BLOCKS
constant. This will require refactoring some of the networking code, and should probably happen as part of the Deneb work (to avoid merge conflicts, and because Deneb also touches this code). I'll close the original issue and open a new one.
There is #4562 @michaelsproul |
Ah! Thanks @divagant-martian, didn't see that! |
@michaelsproul |
HI @duguorong009 bare in mind that I'm not a team member but I know about this to some depth. What @michaelsproul is describing is that the changes you made address the issue partially and we want to address it fully. "Using" this value is what #4562 describes. This has not been done because in terms of code, it's not clear for us what's the best way to do it. Or at least it's definitely not straightforward. This being said, re-targeting to deneb is not going to be enough, sadly |
Thanks for the quick answer! @divagant-martian If you and @michaelsproul find a wayout, and think this PR can continue, please let me know. |
Thanks for your work on this @duguorong009, it helped us clarify the issue. I'm going to close your PR now in favour of the more involved fix here: #4841. |
Issue Addressed
Proposed Changes
ChainSpec
struct ofconsensus
crateAdd the
max_request_blocks
fieldAdditional Info
Originally, this PR is for addressing the issue of missing the
MAX_REQUEST_BLOCKS
info from lighthouse beacon API/eth/v1/config/spec
.While resolving the issue, I found that we don't need to update anything from BN crate code, but update the
ChainSpec
fromconsensus
crate.Hence, the PR is for updating the
consensus
crate, adding one more field toChainSpec
struct and related codes.