Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Show --gui flag in help text #4660

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Show --gui flag in help text #4660

wants to merge 1 commit into from

Conversation

macladson
Copy link
Member

Issue Addressed

N/A

Proposed Changes

Remove the hidden(true) modifier on the --gui flag so it shows up when running lighthouse bn --help

Additional Info

We need to include this now that Siren has had its first stable release.

@macladson macladson added ready-for-review The code is ready for review v4.4.1 ETA August 2023 labels Aug 25, 2023
michaelsproul
michaelsproul approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 25, 2023
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 25, 2023
@macladson
Show --gui flag in help text (#4660)
eb0849c 
## Issue Addressed

N/A

## Proposed Changes

Remove the `hidden(true)` modifier on the `--gui` flag so it shows up when running `lighthouse bn --help`

## Additional Info

We need to include this now that Siren has had its first stable release.
@bors
Copy link

bors bot commented Aug 25, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 25, 2023
@macladson
Show --gui flag in help text (#4660)
1c7cf1a 
## Issue Addressed

N/A

## Proposed Changes

Remove the `hidden(true)` modifier on the `--gui` flag so it shows up when running `lighthouse bn --help`

## Additional Info

We need to include this now that Siren has had its first stable release.
@bors
Copy link

bors bot commented Aug 25, 2023

Build failed:

@michaelsproul
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Aug 25, 2023
@macladson
Show --gui flag in help text (#4660)
7f3507d 
## Issue Addressed

N/A

## Proposed Changes

Remove the `hidden(true)` modifier on the `--gui` flag so it shows up when running `lighthouse bn --help`

## Additional Info

We need to include this now that Siren has had its first stable release.
@bors
Copy link

bors bot commented Aug 25, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 25, 2023
@macladson
Show --gui flag in help text (#4660)
473de7f 
## Issue Addressed

N/A

## Proposed Changes

Remove the `hidden(true)` modifier on the `--gui` flag so it shows up when running `lighthouse bn --help`

## Additional Info

We need to include this now that Siren has had its first stable release.
@michaelsproul
Copy link
Member

bors r-

until we fix the web3signer issue this isn't going to work

@bors
Copy link

bors bot commented Aug 25, 2023

Canceled.

@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 28, 2023
@macladson
Show --gui flag in help text (#4660)
55e02e7 
## Issue Addressed

N/A

## Proposed Changes

Remove the `hidden(true)` modifier on the `--gui` flag so it shows up when running `lighthouse bn --help`

## Additional Info

We need to include this now that Siren has had its first stable release.
@bors
Copy link

bors bot commented Aug 28, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Show --gui flag in help text [Merged by Bors] - Show --gui flag in help text Aug 28, 2023
@bors bors bot closed this Aug 28, 2023
@macladson macladson deleted the unhide-gui branch August 28, 2023 01:45
jxs pushed a commit to jxs/lighthouse that referenced this pull request Aug 28, 2023
@macladson @jxs
Show --gui flag in help text (sigp#4660)
3f44903 
## Issue Addressed

N/A

## Proposed Changes

Remove the `hidden(true)` modifier on the `--gui` flag so it shows up when running `lighthouse bn --help`

## Additional Info

We need to include this now that Siren has had its first stable release.
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@macladson @Woodpile37
Show --gui flag in help text (sigp#4660)
292b81b 
## Issue Addressed

N/A

## Proposed Changes

Remove the `hidden(true)` modifier on the `--gui` flag so it shows up when running `lighthouse bn --help`

## Additional Info

We need to include this now that Siren has had its first stable release.
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@macladson @Woodpile37
Show --gui flag in help text (sigp#4660)
06637d1 
## Issue Addressed

N/A

## Proposed Changes

Remove the `hidden(true)` modifier on the `--gui` flag so it shows up when running `lighthouse bn --help`

## Additional Info

We need to include this now that Siren has had its first stable release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge. v4.4.1 ETA August 2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macladson @michaelsproul @paulhauner