Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iron HTTP server #391

Merged
merged 10 commits into from
May 27, 2019
Prev Previous commit
Next Next commit
Improve comments for http_server
  • Loading branch information
paulhauner committed May 27, 2019
commit 3a65f84b129100d405d7e441a29a1d4659517704
1 change: 1 addition & 0 deletions beacon_node/http_server/src/api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ use router::Router;
use serde_json::json;
use std::sync::Arc;

/// Yields a handler for the HTTP API.
pub fn build_handler<T: BeaconChainTypes + 'static>(
beacon_chain: Arc<BeaconChain<T>>,
) -> impl Handler {
Expand Down
2 changes: 1 addition & 1 deletion beacon_node/http_server/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ pub fn start_service<T: BeaconChainTypes + 'static>(
info!(log, "HTTP server shutting down");

if let Ok(mut server) = server_start_result {
// According to the documentation, this function "doesn't work" and the server
// According to the documentation, `server.close()` "doesn't work" and the server
// keeps listening.
//
// It is being called anyway, because it seems like the right thing to do. If you
Expand Down
1 change: 1 addition & 0 deletions beacon_node/http_server/src/metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ use slot_clock::SlotClock;
use std::sync::Arc;
use types::Slot;

/// Yields a handler for the metrics endpoint.
pub fn build_handler<T: BeaconChainTypes + 'static>(
beacon_chain: Arc<BeaconChain<T>>,
) -> impl Handler {
Expand Down