Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure codebase #26

Merged
merged 29 commits into from
Oct 2, 2018
Merged

Restructure codebase #26

merged 29 commits into from
Oct 2, 2018

Conversation

paulhauner
Copy link
Member

Move over to a more crate-based approach.

@paulhauner
Add block validation code
9dcec21 
This was created in another branch along with a whole bunch of other
commits building out databases and other common elements.

This full history of these works is available on master, however it
should not be necessary.
@paulhauner
Split block validation tests into functions
84bb408
@paulhauner
Add first block validation benches
a8b08fb
@paulhauner
Move attestation validation into iter.for_each
debc642
@paulhauner
Fix bug with bitfield validation
05fe231
@paulhauner
Add (untested) parallelization for att validation
b92d88d
@paulhauner
Refact block val. tests to be more modular
19ddbde
@paulhauner
Refactor block val. benches to use test funtions
8020b89
@paulhauner
Tidy benches file
13467ab
@paulhauner
Tidy comments in block validation
7c88f94
@paulhauner
Introduce "benches" feature
e0e8aa9 
So that benchmarks don't run each time tests run
@paulhauner
Further development on block validation
bc27be1 
- Return a fully deserialized block from validate_ssz_block
- Ensure the parent_hash field is handled
@paulhauner
Refactor block val. into "BlockValidationContext"
0b99951
@paulhauner
Rename block_store functions
385564d 
 - Specified that the block is "serialized".
@paulhauner
Progress further with block validation
5dd2361 
- Rename errors returned from SszBlock.
- Add parent_hash concept to block validation.
- Add more comments to block validation.
@paulhauner
Simplify block validation tests
9642c4b 
Move more parameters into get_simple_params()
@paulhauner
Fix bug in boolean bitfield
a87fe88 
The length generated when converting from a string was incorrect.
@paulhauner
Fix bug in attestation val. bitfield checking
496adc0 
There was a logic error
@paulhauner
Implement more tests for block validation
77b48b9
@paulhauner
Update benchmarks as per recent code changes
29ed29c
@paulhauner
Remove "benches" feature
b426c9e 
Now benches just live with the rest of the code in the default feature.
@paulhauner
Introduce AttestationValidationContext
c3ec8a3 
This reduced code duplication.
@paulhauner
Restructure block validation directory
4d1f730
@paulhauner
Refactor validation tests into integration tests
8f52858
@paulhauner
Implement framework for testing attestation val.
8e094b3
@paulhauner
Update block and attestation validation code
6b7677a
@paulhauner
Add test for attestation msg generation
cd3b2f5
@paulhauner
Add tests for attestation_validation
07bfd7e
@paulhauner
Heavily restructure repo
0fbe417 
Separate most modules into crates
@paulhauner paulhauner merged commit 6a75aa3 into master Oct 2, 2018
@paulhauner paulhauner deleted the restructure branch October 9, 2018 02:42
michaelsproul added a commit that referenced this pull request Apr 30, 2024
@michaelsproul
Merge parent and current sync lookups (#5660)
0d5c21a 
Squashed commit of the following:

commit 0203843
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Tue Apr 30 15:14:30 2024 +0900

    Various fixes

commit 9d185d1
Author: realbigsean <seananderson33@GMAIL.com>
Date:   Tue Apr 30 01:59:05 2024 -0400

    #5655 pr review (#26)

    * fix compile after merge

    * remove todos, fix typos etc

    * fix compile

    * stable rng

    * delete TODO and unfilled out test

    * make download result a struct

    * enums instead of bools as params

    * fix comment

commit 4bde25b
Author: realbigsean <seananderson33@GMAIL.com>
Date:   Mon Apr 29 21:29:55 2024 -0400

    fix compile after merge

commit c309c07
Merge: 13bc011 c8ffafb
Author: realbigsean <seananderson33@GMAIL.com>
Date:   Mon Apr 29 21:29:29 2024 -0400

    Merge branch 'unstable' of https://github.com/sigp/lighthouse into sync-merged-lookup

commit 13bc011
Merge: bad87b1 8b24880
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Sat Apr 27 12:16:29 2024 +0900

    Merge remote-tracking branch 'origin/unstable' into sync-merged-lookup

commit bad87b1
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Fri Apr 26 10:32:23 2024 +0900

    Merge current and parent lookups tests

commit 5d29618
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Thu Apr 25 21:59:22 2024 +0900

    Merge current and parent lookups clean up todos

commit 611c37a
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Wed Apr 24 08:52:06 2024 +0900

    Merge current and parent lookups

commit 3b662de
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Tue Apr 23 15:14:17 2024 +0900

    Send parent blocks one by one

commit 4c8143f
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Tue Apr 23 01:28:53 2024 +0900

    Drop reconstructed for processing

commit e0b862b
Author: dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Tue Apr 23 01:14:26 2024 +0900

    Drop lookup type trait for a simple arg
mergify bot pushed a commit that referenced this pull request Apr 30, 2024
@realbigsean
#5655 pr review (#26)
9d185d1 
* fix compile after merge

* remove todos, fix typos etc

* fix compile

* stable rng

* delete TODO and unfilled out test

* make download result a struct

* enums instead of bools as params

* fix comment
mergify bot pushed a commit that referenced this pull request Apr 30, 2024
@dapplion
Merge parent and current sync lookups (#5655)
ce66582 
* Drop lookup type trait for a simple arg

* Drop reconstructed for processing

* Send parent blocks one by one

* Merge current and parent lookups

* Merge current and parent lookups clean up todos

* Merge current and parent lookups tests

* Merge remote-tracking branch 'origin/unstable' into sync-merged-lookup

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into sync-merged-lookup

* fix compile after merge

* #5655 pr review (#26)

* fix compile after merge

* remove todos, fix typos etc

* fix compile

* stable rng

* delete TODO and unfilled out test

* make download result a struct

* enums instead of bools as params

* fix comment

* Various fixes

* Track ignored child components

* Track dropped lookup reason as metric

* fix test

* add comment describing behavior of avail check error

*  update ordering
ethDreamer added a commit that referenced this pull request May 2, 2024
@ethDreamer @realbigsean
@macladson @dapplion @pawanjay176 @rkrasiuk @eserilev @antondlr @jimmygchen @Arvmor @AgeManning @jxs @michaelsproul
Electra attestation changes (#5697)
cd0f08b 
* Fix execution integration tests (#5647)

* update waiting status

* revert to old nethermind version

* Add electra presets to beacon API (#5630)

* add presets to API

* add extra fields to config spec in beacon API

* remove unused

* add mainnet presets for gnosis and fix minimal preset default values

* Rename `Merge` to `Bellatrix` (#5601)

* Rename Merge to Bellatrix

* Remove tree-hash-cache which got readded from the rebase

* Deterministic block generation for tests (#5654)

* Deterministic block generation for tests

* Electra other containers (#5652)

* add new fields to execution payload and header

* beacon state changes

* partial beacon state

* safe arith in upgrade to electra

* initialize balances cache in interop genesis state

* Revert "initialize balances cache in interop genesis state"

This reverts commit c60b522.

* always initialize balances cache if necessary in electra upgrade

* build cache earlier

* fix block test

* per fork NUM_FIELDS_POW2

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into electra-other-containers

* fix lints

* get fields based on post state, as is spec'd

* fix type and move cache build

* Add more electra helpers (#5653)

* Add new helpers

* Fix some stuff

* Fix compilation errors

* lint

* Address review

* Ignore gossip blob already imported (#5656)

* Ignore gossip blob already imported

* Beta compiler fix (#5659)

* fix beta compiler compilation

* remove unused import

* Revert "remove unused import"

This reverts commit 0bef36b.

* Revert "fix beta compiler compilation"

This reverts commit 23152cf.

* rename ununsed fields

* allow dead code on some error variants

* remove unused blob download queue

* add back debug to backfill error

* more allow dead code on errors

* fix(validator_client): raise soft fd limit (#4796)

* fix(validator_client): raise soft fd limit

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into rkrasiuk/raise-vc-fdlimit

* cargo lock

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into rkrasiuk/raise-vc-fdlimit

* Proposer and attester slashing sse events (#5327)

* default vc to block v3 endpoint and deprecate block-v3 flag

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into unstable

* add proposer and attester event variants

* add TOOOs

* add tests, event triggers

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events

* revert

* revert

* remove double event tracking

* Merge branch 'unstable' into proposer-and-attester-slashing-sse-events

* remove todo, fix test

* resolve merge conflicts

* Merge branch 'proposer-and-attester-slashing-sse-events' of https://github.com/eserilev/lighthouse into proposer-and-attester-slashing-sse-events

* leftover debugging

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events

* pin macos release runner to `macos-13` (#5665)

* pin macos release runner to `macos-13`

* Update .github/workflows/release.yml

* Remove snapshot cache related code (#5661)

* Remove snapshot cache and other references.

* Fix default state cache size in docs

* Remove cache miss comment entirely

* Add state cache CLI tests

* Uncomment self_hosted_runner after PR Merge #5137 (#5291)

* Uncomment self_hosted_runner after PR Merge #5137

* Merge branch 'unstable' into fix_todo

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into fix_todo

* Only `portable` builds (binaries) (#5615)

* release workflow: portable builds by default

* Delete outdated comment

* Merge branch 'unstable' into portable-builds-binaries

# Conflicts:
#	.github/workflows/release.yml

* Merge parent and current sync lookups (#5655)

* Drop lookup type trait for a simple arg

* Drop reconstructed for processing

* Send parent blocks one by one

* Merge current and parent lookups

* Merge current and parent lookups clean up todos

* Merge current and parent lookups tests

* Merge remote-tracking branch 'origin/unstable' into sync-merged-lookup

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into sync-merged-lookup

* fix compile after merge

* #5655 pr review (#26)

* fix compile after merge

* remove todos, fix typos etc

* fix compile

* stable rng

* delete TODO and unfilled out test

* make download result a struct

* enums instead of bools as params

* fix comment

* Various fixes

* Track ignored child components

* Track dropped lookup reason as metric

* fix test

* add comment describing behavior of avail check error

*  update ordering

*  delete spammy log (#5672)

*  delete spammy log

* Ensure block only range requests don't fail on download (#5675)

* ensure pruned blobs don't fail on download

* Typo

* Improve ENR updates (#5483)

* Improve ENR updates

* forever fmt

* Appease my old friend clippy

* Merge network unstable

* Check da_checker before doing a block lookup request (#5681)

* Check da_checker before doing a block lookup request

* Ensure consistent handling of lookup result

* use req resp pre import cache rather than da checker

* Update Cargo.lock (#5670)

* update rust-yamux

* update Cargo.lock

* Merge branch 'unstable' of github.com:jxs/lighthouse into update-cargo

* Merge branch 'unstable' of github.com:sigp/lighthouse into update-cargo

* update to new libp2p versions

* Add metric for current epoch total balance (#5688)

* Add metric for current epoch total balance

---------

Co-authored-by: realbigsean <sean@sigmaprime.io>
Co-authored-by: Mac L <mjladson@pm.me>
Co-authored-by: Lion - dapplion <35266934+dapplion@users.noreply.github.com>
Co-authored-by: Pawan Dhananjay <pawandhananjay@gmail.com>
Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com>
Co-authored-by: Eitan Seri-Levi <eserilev@ucsc.edu>
Co-authored-by: antondlr <anton@delaruelle.net>
Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>
Co-authored-by: Ærvin <arvin.morawej@gmail.com>
Co-authored-by: Age Manning <Age@AgeManning.com>
Co-authored-by: João Oliveira <hello@jxs.pt>
Co-authored-by: Michael Sproul <michael@sigmaprime.io>
ethDreamer pushed a commit to ethDreamer/lighthouse that referenced this pull request May 3, 2024
@dapplion @ethDreamer
Merge parent and current sync lookups (sigp#5655)
5cca3bf 
* Drop lookup type trait for a simple arg

* Drop reconstructed for processing

* Send parent blocks one by one

* Merge current and parent lookups

* Merge current and parent lookups clean up todos

* Merge current and parent lookups tests

* Merge remote-tracking branch 'origin/unstable' into sync-merged-lookup

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into sync-merged-lookup

* fix compile after merge

* sigp#5655 pr review (sigp#26)

* fix compile after merge

* remove todos, fix typos etc

* fix compile

* stable rng

* delete TODO and unfilled out test

* make download result a struct

* enums instead of bools as params

* fix comment

* Various fixes

* Track ignored child components

* Track dropped lookup reason as metric

* fix test

* add comment describing behavior of avail check error

*  update ordering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paulhauner