[Merged by Bors] - Increase logging channel capacity #1570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Looks good to me, would be interested to see if @paulhauner has any thoughts
paulhauner
approved these changes
Aug 27, 2020
…ease-logging-channel-capacity # Conflicts: # Cargo.lock
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 31, 2020
## Issue Addressed #1464 ## Proposed Changes Increase the slog-async log channel size from the default of 128 to 2048 to reduce the number of dropped logs. ## Additional Info
|
Pull request successfully merged into master. Build succeeded: |
darcys22
pushed a commit
to darcys22/lighthouse
that referenced
this pull request
Sep 5, 2020
## Issue Addressed sigp#1464 ## Proposed Changes Increase the slog-async log channel size from the default of 128 to 2048 to reduce the number of dropped logs. ## Additional Info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#1464
Proposed Changes
Increase the slog-async log channel size from the default of 128 to 2048 to reduce the number of dropped logs.
Additional Info