Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Allow import of Prysm keystores #1535

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Allow import of Prysm keystores #1535

wants to merge 4 commits into from

Conversation

paulhauner
Copy link
Member

Issue Addressed

Proposed Changes

Loosens the constraints imposed by EIP-2335 so we can import keys from Prysm.

Additional Info

NA

@paulhauner paulhauner added the ready-for-review The code is ready for review label Aug 18, 2020
@paulhauner paulhauner mentioned this pull request Aug 18, 2020
Closed
kirk-baird
kirk-baird approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@kirk-baird kirk-baird left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this works from the prysm validator accounts-v2 backup functionality.

Some of the release tests need to be updated in crypto/eth2_wallet/tests/tests.rs

@paulhauner
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Aug 18, 2020
@paulhauner
Allow import of Prysm keystores (#1535)
46dd530 
## Issue Addressed

- Resolves #1361

## Proposed Changes

Loosens the constraints imposed by EIP-2335 so we can import keys from Prysm.

## Additional Info

NA
@bors
Copy link

bors bot commented Aug 18, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Allow import of Prysm keystores [Merged by Bors] - Allow import of Prysm keystores Aug 18, 2020
@bors bors bot closed this Aug 18, 2020
@paulhauner paulhauner deleted the prysm-key-import branch September 18, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirk-baird kirk-baird kirk-baird approved these changes

Assignees
No one assigned
Labels
ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to parse validator voting keystore from ethdo
2 participants
@paulhauner @kirk-baird