Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Ensure RUSTFLAGS is passed through on cross compile #1529

Closed
wants to merge 1 commit into from

Conversation

paulhauner
Copy link
Member

Issue Addressed

NA

Proposed Changes

Tells cross (used for cross-compiling) to read the RUSTFLAGSenv and pass it through during build. This allows us to use -g and get debug info.

Additional Info

NA

@paulhauner paulhauner added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! labels Aug 17, 2020
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 17, 2020
@paulhauner
Copy link
Member Author

I think that macos failure will go away when bors runs.

bors r+

bors bot pushed a commit that referenced this pull request Aug 17, 2020
## Issue Addressed

NA

## Proposed Changes

Tells `cross` (used for cross-compiling) to read the `RUSTFLAGS`env and pass it through during build. This allows us to use `-g` and get debug info. 

## Additional Info

NA
@bors
Copy link

bors bot commented Aug 17, 2020

Build failed:

@paulhauner
Copy link
Member Author

bors retry

bors bot pushed a commit that referenced this pull request Aug 17, 2020
## Issue Addressed

NA

## Proposed Changes

Tells `cross` (used for cross-compiling) to read the `RUSTFLAGS`env and pass it through during build. This allows us to use `-g` and get debug info. 

## Additional Info

NA
@bors
Copy link

bors bot commented Aug 17, 2020

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request Aug 17, 2020
## Issue Addressed

NA

## Proposed Changes

Tells `cross` (used for cross-compiling) to read the `RUSTFLAGS`env and pass it through during build. This allows us to use `-g` and get debug info. 

## Additional Info

NA
@bors bors bot changed the title Ensure RUSTFLAGS is passed through on cross compile [Merged by Bors] - Ensure RUSTFLAGS is passed through on cross compile Aug 17, 2020
@bors bors bot closed this Aug 17, 2020
@paulhauner paulhauner deleted the cross-rustflags branch October 5, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants