Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Allow to use the same password when importing multiple keystores (#1479) #1510

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Allow to use the same password when importing multiple keystores (#1479) #1510

wants to merge 2 commits into from

Conversation

adetante
Copy link
Contributor

Issue Addressed

#1479

Proposed Changes

  • Add an optional flag reuse-password in the import command of account_manager, allowing to use the same password for all imported keystores.

@CLAassistant
Copy link

CLAassistant commented Aug 11, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@paulhauner
Copy link
Member

Thanks @adetante, this looks good from a cursory glance!

I'm just following up on a deadlock at the moment, but I'll come back to this when I get a moment :)

@paulhauner paulhauner added ready-for-review The code is ready for review enhancement New feature or request labels Aug 13, 2020
@adetante
Copy link
Contributor Author

No problem!

This is my first (very) modest contribution to Lighthouse, but I'd like to go more into the details of the client afterwards ;-)

paulhauner
paulhauner approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flawless, thank you!

bors r+

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Sep 4, 2020
bors bot pushed a commit that referenced this pull request Sep 4, 2020
@adetante
Allow to use the same password when importing multiple keystores (#1479…
9c9176c 
…) (#1510)

## Issue Addressed

#1479 

## Proposed Changes

* Add an optional flag `reuse-password` in the `import` command of account_manager, allowing to use the same password for all imported keystores.
@bors
Copy link

bors bot commented Sep 4, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Allow to use the same password when importing multiple keystores (#1479) [Merged by Bors] - Allow to use the same password when importing multiple keystores (#1479) Sep 4, 2020
@bors bors bot closed this Sep 4, 2020
darcys22 pushed a commit to darcys22/lighthouse that referenced this pull request Sep 5, 2020
@adetante @darcys22
Allow to use the same password when importing multiple keystores (sig…
72317d8 
…p#1479) (sigp#1510)

## Issue Addressed

sigp#1479 

## Proposed Changes

* Add an optional flag `reuse-password` in the `import` command of account_manager, allowing to use the same password for all imported keystores.
@paulhauner paulhauner mentioned this pull request Sep 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adetante @CLAassistant @paulhauner