[Merged by Bors] - Cross-compile to vendored x86_84, aarch64 (Raspberry Pi 4) #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit of the following: commit fe3ecc0 Author: Age Manning <Age@AgeManning.com> Date: Mon Aug 10 13:59:29 2020 +1000 Report port overlapping and failure to bind to user commit d3dc6a9 Author: Age Manning <Age@AgeManning.com> Date: Mon Aug 10 12:01:27 2020 +1000 Upgrade address conflict logs
912134f to
48fd312
Compare
michaelsproul
requested changes
Aug 11, 2020
| > Note: if you're not familiar with Rust or you'd like more detailed instructions, see our [installation guide](./installation.md). | ||
| > Notes: | ||
| > - If you're not familiar with Rust or you'd like more detailed instructions, see our [installation guide](./installation.md). | ||
| > - Windows is presently only supported via [WSL](target/aarch64-unknown-linux-gnu). |
There was a problem hiding this comment.
typo in link target, should be WSL not aarch64
book/src/cross-compiling.md
Outdated
| @@ -0,0 +1,41 @@ | |||
| # Cross-compiling | |||
|
|
|||
| Lighthouse supports cross-compiling, allowing users to run a binary one | |||
| for most users). | ||
| - `build-x86_64-portable`: builds a version x86_64 processors which avoids | ||
| using some modern CPU instructions that might cause an "illegal | ||
| instruction" error on older CPUs. |
There was a problem hiding this comment.
There's still an issue with pre-SSSE3 CPUs. I've opened #1504 to track it
|
|
||
| The `Makefile` in the project contains four targets for cross-compiling: | ||
|
|
||
| - `build-x86_64`: builds an optimized version for x86_64 processors (suitable |
There was a problem hiding this comment.
I'm surprised that this produces a portable binary, but it seems to (I ran the v0.2.2 release on my laptop just fine). The binary must still be compiled with -march=native inside the Docker image, which would tailor it to the host machine, so I'm not sure if we just got lucky with the choice of host. I've opened #1505 to track this.
|
Thanks @michaelsproul, I believe I added all the changes required for now. |
bors bot
pushed a commit
that referenced
this pull request
Aug 11, 2020
## Issue Addressed NA ## Proposed Changes Adds support for using the [`cross`](https://github.com/rust-embedded/cross) project to produce cross-compiled binaries using Docker images. Provides quite clean and simple cross-compiles cause all the complexity is hidden in Dockerfiles. It does require you to be in the `docker` group though. ## Details - Adds shortcut commands to `Makefile` - Ensures `reqwest` and `discv5` use vendored openssl libs (i.e., static not shared). - Switches to a [commit](sigp/blst@284f705) of blst that has a renamed C function to avoid a collision with openssl (upstream issue: supranational/blst#21). - Updates `ring` to the latest satisfiable version, since an earlier version was causing issues with `cross`. - Off-topic, but adds extra message about Windows support as suggested by Discord user. ## Additional Info - ~~Blocked on #1495~~ - There are no tests in CI for this yet for a few reasons: - I'm hesitant to add more long-running tasks. - Short-term bitrot should be avoided since we'll use it each release. - In the long term I think it would be good to automate binary creation on a release. - I observed the binaries increase in size from 50mb to 52mb after these changes.
|
Pull request successfully merged into master. Build succeeded: |
paulhauner
added a commit
that referenced
this pull request
Aug 12, 2020
## Issue Addressed NA ## Proposed Changes Adds support for using the [`cross`](https://github.com/rust-embedded/cross) project to produce cross-compiled binaries using Docker images. Provides quite clean and simple cross-compiles cause all the complexity is hidden in Dockerfiles. It does require you to be in the `docker` group though. ## Details - Adds shortcut commands to `Makefile` - Ensures `reqwest` and `discv5` use vendored openssl libs (i.e., static not shared). - Switches to a [commit](sigp/blst@284f705) of blst that has a renamed C function to avoid a collision with openssl (upstream issue: supranational/blst#21). - Updates `ring` to the latest satisfiable version, since an earlier version was causing issues with `cross`. - Off-topic, but adds extra message about Windows support as suggested by Discord user. ## Additional Info - ~~Blocked on #1495~~ - There are no tests in CI for this yet for a few reasons: - I'm hesitant to add more long-running tasks. - Short-term bitrot should be avoided since we'll use it each release. - In the long term I think it would be good to automate binary creation on a release. - I observed the binaries increase in size from 50mb to 52mb after these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Adds support for using the
crossproject to produce cross-compiled binaries using Docker images.Provides quite clean and simple cross-compiles cause all the complexity is hidden in Dockerfiles. It does require you to be in the
dockergroup though.Details
Makefilereqwestanddiscv5use vendored openssl libs (i.e., static not shared).ringto the latest satisfiable version, since an earlier version was causing issues withcross.Additional Info
Blocked on [Merged by Bors] - Upgrade logs #1495