Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Ensure .git is copied into docker #1462

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Ensure .git is copied into docker #1462

wants to merge 1 commit into from

Conversation

paulhauner
Copy link
Member

Issue Addressed

Proposed Changes

Copy the .git directory across when building docker so we can get commit information.

Unfortunately this means duplicating you .git directory which might be quite large (mine is >100mb). Notably this directory isn't contained in the final image, just the intermediate builder image.

Additional Info

NA

@paulhauner paulhauner added work-in-progress PR is a work-in-progress low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Aug 5, 2020
@paulhauner paulhauner marked this pull request as ready for review August 5, 2020 02:11
@michaelsproul michaelsproul changed the title Ensure .git is compied into docker Ensure .git is copied into docker Aug 5, 2020
michaelsproul
michaelsproul approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

bors r+

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 5, 2020
bors bot pushed a commit that referenced this pull request Aug 5, 2020
@paulhauner
Ensure .git is copied into docker (#1462)
6206d8e 
## Issue Addressed

- Resolves #1461 

## Proposed Changes

Copy the `.git` directory across when building docker so we can get commit information.

Unfortunately this means duplicating you `.git` directory which might be quite large (mine is >100mb). Notably this directory isn't contained in the final image, just the intermediate builder image.

## Additional Info

NA
@bors
Copy link

bors bot commented Aug 5, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Ensure .git is copied into docker [Merged by Bors] - Ensure .git is copied into docker Aug 5, 2020
@bors bors bot closed this Aug 5, 2020
@paulhauner paulhauner deleted the git-in-docker branch October 5, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker does not build with version tag
2 participants
@paulhauner @michaelsproul