[Merged by Bors] - Add ability to configure CORS header #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
requested changes
Jul 14, 2020
paulhauner
reviewed
Jul 14, 2020
beacon_node/src/cli.rs
Outdated
| Arg::with_name("http-allow-origin") | ||
| .long("http-allow-origin") | ||
| .value_name("ORIGIN") | ||
| .help("Set the value of the Access-Control-Allow-Origin response HTTP header") |
There was a problem hiding this comment.
Do you think it might be helpful to add Put *, to allow any origin (or similar) to this help text? I'm not sure I'd know what to set it to.
There was a problem hiding this comment.
Added. It won't do any harm.
787a56e to
760e936
Compare
bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2020
## Issue Addressed #1177 ## Proposed Changes Add a command line option (`--http-allow-origin`) and a config item for configuring the `Access-Control-Allow-Origin` response header. This should unblock making XMLHttpRequests.
|
Pull request successfully merged into master. Build succeeded: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#1177
Proposed Changes
Add a command line option (
--http-allow-origin) and a config item for configuring theAccess-Control-Allow-Originresponse header. This should unblock making XMLHttpRequests.