Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two copies of validator_definitions.yml #1427

Closed
michaelsproul opened this issue Jul 31, 2020 · 3 comments
Closed

Two copies of validator_definitions.yml #1427

michaelsproul opened this issue Jul 31, 2020 · 3 comments
Labels
UX-and-logs

Comments

@michaelsproul
Copy link
Member

Description

I'm seeing two copies of validator_definitions.yml, one in ~/.altona/ and the other in ~/.altona/validators (~/.altona is my validator dir). I don't have time to investigate now, but it looks like there's something strange going on

Version

Lighthouse 0.1.2-2ede9caa
@ghost ghost added A0 UX-and-logs labels Sep 9, 2020
@michaelsproul
Copy link
Member Author

I'm fairly sure this will be resolved by #1532 (I had my datadirs confused)

@michaelsproul michaelsproul mentioned this issue Sep 22, 2020
Closed
bors bot pushed a commit that referenced this issue Sep 29, 2020
@pawanjay176 @realbigsean @paulhauner
Directory restructure (#1532)
2ad3a09 
## Issue Addressed

Closes #1487
Closes #1427

## Proposed Changes

Directory restructure in accordance with #1487. Also has temporary migration code to move the old directories into new structure.
Also extracts all default directory names and utility functions into a `directory` crate to avoid repetitio.

## Additional info

~Since `validator_definition.yaml` stores absolute paths, users will have to manually change the keystore paths or delete the file to get the validators picked up by the vc.~. `validator_definition.yaml` is migrated as well from the default directories.

Co-authored-by: realbigsean <seananderson33@gmail.com>
Co-authored-by: Paul Hauner <paul@paulhauner.com>
@paulhauner
Copy link
Member

Resolved via #1532 (I think?)

@michaelsproul
Copy link
Member Author

Yep!

paulhauner added a commit that referenced this issue Sep 29, 2020
@pawanjay176 @realbigsean @paulhauner
Directory restructure (#1532)
137966d 
Closes #1487
Closes #1427

Directory restructure in accordance with #1487. Also has temporary migration code to move the old directories into new structure.
Also extracts all default directory names and utility functions into a `directory` crate to avoid repetitio.

~Since `validator_definition.yaml` stores absolute paths, users will have to manually change the keystore paths or delete the file to get the validators picked up by the vc.~. `validator_definition.yaml` is migrated as well from the default directories.

Co-authored-by: realbigsean <seananderson33@gmail.com>
Co-authored-by: Paul Hauner <paul@paulhauner.com>
paulhauner added a commit that referenced this issue Oct 1, 2020
@pawanjay176 @realbigsean @paulhauner
Directory restructure (#1532)
8e20176 
Closes #1487
Closes #1427

Directory restructure in accordance with #1487. Also has temporary migration code to move the old directories into new structure.
Also extracts all default directory names and utility functions into a `directory` crate to avoid repetitio.

~Since `validator_definition.yaml` stores absolute paths, users will have to manually change the keystore paths or delete the file to get the validators picked up by the vc.~. `validator_definition.yaml` is migrated as well from the default directories.

Co-authored-by: realbigsean <seananderson33@gmail.com>
Co-authored-by: Paul Hauner <paul@paulhauner.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UX-and-logs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Directory restructure pawanjay176/lighthouse
2 participants
@michaelsproul @paulhauner