address review

sigp · Feb 19, 2024 · 3c229f3 · 3c229f3
1 parent 0fa03b7
commit 3c229f3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/beacon_node/lighthouse_network/Cargo.toml b/beacon_node/lighthouse_network/Cargo.toml
@@ -64,7 +64,7 @@ quick-protobuf-codec = "0.3"
 [dependencies.libp2p]
 version = "0.53"
 default-features = false
-features = ["identify", "yamux", "noise", "gossipsub", "dns", "tcp", "tokio", "plaintext", "secp256k1", "macros", "ecdsa", "metrics", "quic", "upnp"]
+features = ["identify", "yamux", "noise", "dns", "tcp", "tokio", "plaintext", "secp256k1", "macros", "ecdsa", "metrics", "quic", "upnp"]
 
 [dev-dependencies]
 slog-term = { workspace = true }

diff --git a/beacon_node/network/src/service.rs b/beacon_node/network/src/service.rs
@@ -236,14 +236,17 @@ impl<T: BeaconChainTypes> NetworkService<T> {
         ) {
             let nw = network_log.clone();
             let v4 = v4.clone();
-            tokio::spawn(async move {
-                info!(nw, "UPnP Attempting to initialise routes");
-                if let Err(e) =
-                    nat::construct_upnp_mappings(v4.addr, v4.disc_port, nw.clone()).await
-                {
-                    info!(nw, "Could not UPnP map Discovery port"; "error" => %e);
-                }
-            });
+            executor.spawn(
+                async move {
+                    info!(nw, "UPnP Attempting to initialise routes");
+                    if let Err(e) =
+                        nat::construct_upnp_mappings(v4.addr, v4.disc_port, nw.clone()).await
+                    {
+                        info!(nw, "Could not UPnP map Discovery port"; "error" => %e);
+                    }
+                },
+                "UPnP",
+            );
         }
 
         // get a reference to the beacon chain store