Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwrap clippy #66

Closed
wants to merge 5 commits into from
Closed

Unwrap clippy #66

wants to merge 5 commits into from

Conversation

jking-aus
Copy link
Contributor

fix clippy in client/cli.rs

@jking-aus jking-aus requested a review from dknopik December 6, 2024 02:20
dknopik
dknopik reviewed Dec 6, 2024
View reviewed changes
Copy link
Member

@dknopik dknopik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shows as having no files changed after merging - therefore, lgtm :D

But I think what happened here is that you also wanted to fix the same thing as I did in #60, which is merged by now - so I think we can close this?

@jking-aus jking-aus closed this Dec 6, 2024
@jking-aus
Copy link
Contributor Author

yep you fixed it in 60 my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dknopik dknopik dknopik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jking-aus @dknopik