-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execution integration #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! great progress @Zacholme7 👏
I know this is WIP, but I thought some early feedback after a quick read might be helpful.
I've added some comments and questions above, and here are a few more:
- Would be useful to add more logging, both for informative and debug purpose (e.g. sync progress, live events received, fetch or processing errors etc)
- I'd love to see some unit & integration tests where it make sense. It doesn't have to be this PR, but I wanted to mention it since we recently started adding tests in the validator client, and it's been a little painful. Adding tests while the codebase is fresh can make things a bit more testable by design and save some headaches later.
I'm not familiar with SSV, so my comments are mostly generic, but I'd like to catch up and review this again later when it's ready.
Overall it's very tidy and nice to read, great job 👍
…nto execution-integration
const MAX_RETRIES: i32 = 5; | ||
|
||
// Block follow distance | ||
const FOLLOW_DISTANCE: u64 = 8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check with ssv on reason for 8 block follow distance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed in call on 14/1 -- nice work zac good to get this one finished
Issue Addressed
Proposed Changes
This PR tracks the integration of the execution layer into anchor. The process can be thought of as the following:
Additional Info
Types and the database are being worked on alongside this as they all mesh together.