Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/sqlite support #807

Merged
merged 11 commits into from
Apr 22, 2024
Merged

Feat/sqlite support #807

merged 11 commits into from
Apr 22, 2024

Conversation

ohager
Copy link
Member

@ohager ohager commented Apr 15, 2024 •
edited
Loading

Adding sqlite support - hoping that this is more stable than H2.

Further actions:

  • fixes Postgres syncing error on mainnet #780 (same error happened on sqlite)
  • adjusted indirect incoming subqueries to be more preformant on accounts with lots of incomings (needs to be reviewed)
  • refactored Db.class for better maintainability

To do:

  • Sqlite Sync tests tests
  • Run MariaDB Sync tests
  • Run pg Sync
  • Run H2 Sync Tests
  • if successful, remove commented mergeInto statements
  • Add DB_SETUP.md

@ohager ohager requested a review from jjos2372 as a code owner April 15, 2024 11:00
@ohager ohager marked this pull request as draft April 15, 2024 11:03
ohager
ohager commented Apr 19, 2024
View reviewed changes
src/brs/at/AT.java
@@ -39,8 +40,8 @@ public class AT extends AtMachineState {

private AT(byte[] atId, byte[] creator, String name, String description, byte[] creationBytes, int height) {
super(atId, creator, creationBytes, height);
this.name = name;
this.description = description;
this.name = name.trim();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes #780

@ohager ohager marked this pull request as ready for review April 22, 2024 12:02
@ohager ohager merged commit bea2ce8 into develop Apr 22, 2024
2 checks passed
@ohager ohager deleted the feat/sqlite-support branch April 22, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjos2372 jjos2372 Awaiting requested review from jjos2372 jjos2372 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ohager