chore: marked indirect_incoming stuff as buggy...solving in next PR

signum-network · Apr 22, 2024 · 650abc3 · 650abc3
1 parent 8f2400b
commit 650abc3
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/brs/db/sql/SqlBlockchainStore.java b/src/brs/db/sql/SqlBlockchainStore.java
@@ -182,6 +182,8 @@ public Collection<Transaction> getTransactions(Account account, int numberOfConf
       );
 
       if (includeIndirectIncoming) {
+
+        // FIXME: this needs to be reviewed, as it does not deliver 100% correct results.
         int blockTimeStampHeight = getHeightForBlockTimeStamp(blockTimestamp);
         SelectLimitPercentStep<Record1<Long>> indirectIncomings = ctx
           .select(INDIRECT_INCOMING.TRANSACTION_ID)
@@ -269,6 +271,7 @@ public Collection<Transaction> getTransactions(Long senderId, Long recipientId,
         // makes only sense if for recipient. Sender is implicitely included.
         if (!bidirectional && hasRecipient) {
 
+          // FIXME: this needs to be reviewed, as it does not deliver 100% correct results.
           int blockTimeStampHeight = getHeightForBlockTimeStamp(blockTimestamp);
           SelectLimitPercentStep<Record1<Long>> indirectIncomingsForRecipient = ctx
             .select(INDIRECT_INCOMING.TRANSACTION_ID)
@@ -287,6 +290,7 @@ public Collection<Transaction> getTransactions(Long senderId, Long recipientId,
         }
 
         if (bidirectional) {
+          // FIXME: this needs to be reviewed, as it does not deliver 100% correct results.
           int blockTimeStampHeight = getHeightForBlockTimeStamp(blockTimestamp);
           SelectLimitPercentStep<Record1<Long>> indirectIncomingsForBidirectional = ctx
             .select(INDIRECT_INCOMING.TRANSACTION_ID)