refactor: SuggestionsOverlay.js functional component

[Sigrsig]

Converts SuggestionsOverlay.js from class component to functional component

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
react-mentions	✅ Ready (Inspect)	Visit Preview	Jul 12, 2022 at 10:29AM (UTC)

[changeset-bot]

🦋 Changeset detected

Latest commit: 5e284f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
react-mentions	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[dev-talha-akbar]

Flawless, @Sigrsig! 🚀

[dev-talha-akbar]

@Sigrsig One question, however: did someone forget to add customSuggestionsContainer to propTypes before and if yes, now it's there, do we have better prop type than any?

[Sigrsig]

@Sigrsig One question, however: did someone forget to add customSuggestionsContainer to propTypes before and if yes, now it's there, do we have better prop type than any?

That's a good question. I guess it would depend on how the user would use it? If it's only React elements we could use PropTypes.element?

[dev-talha-akbar]

@Sigrsig Based on the code at line 67, could we use PropTypes.func?

[Sigrsig]

Sounds like a plan. I'll do a quick fix for that today!