-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: forceSuggestionsAboveCursor when suggestionsPortalHost is not being used #507
fix: forceSuggestionsAboveCursor when suggestionsPortalHost is not being used #507
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/signavio/react-mentions/AbqTNEbfDWkDT77YcZi1rEa5aCzj |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
=======================================
Coverage 78.84% 78.84%
=======================================
Files 32 32
Lines 695 695
Branches 108 108
=======================================
Hits 548 548
Misses 146 146
Partials 1 1 ☔ View full report in Codecov by Sentry. |
8265bf0
to
8dedc5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for contributing!
Fix forceSuggestionsAboveCursor when suggestionsPortalHost is not being used. Mistake in #449.
Here's a quick repro: https://codesandbox.io/s/react-mentions-forcesuggestionsabovecursor-bug-bq1x0?file=/src/App.js
Resize your browser window so that the suggestions do not fit above the input field to trigger the bug.
Let me know if you need anything else for this fix. Thanks!
By the way, the links on the releases page are not clickable. They render like this:
http://git+https/github.com/signavio/react-mentions/issues/492
. Is this intentional?