Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forceSuggestionsAboveCursor when suggestionsPortalHost is not being used #507

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

stefansundin
Copy link
Contributor

Fix forceSuggestionsAboveCursor when suggestionsPortalHost is not being used. Mistake in #449.

Here's a quick repro: https://codesandbox.io/s/react-mentions-forcesuggestionsabovecursor-bug-bq1x0?file=/src/App.js

Resize your browser window so that the suggestions do not fit above the input field to trigger the bug.

Let me know if you need anything else for this fix. Thanks!

By the way, the links on the releases page are not clickable. They render like this: http://git+https/github.com/signavio/react-mentions/issues/492. Is this intentional?

@vercel
Copy link

vercel bot commented Jul 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/signavio/react-mentions/AbqTNEbfDWkDT77YcZi1rEa5aCzj
✅ Preview: https://react-mentions-git-fork-stefansundin-forcesugge-aa55d4-signavio.vercel.app

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.84%. Comparing base (a2c8856) to head (2b94444).
Report is 78 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #507   +/-   ##
=======================================
  Coverage   78.84%   78.84%           
=======================================
  Files          32       32           
  Lines         695      695           
  Branches      108      108           
=======================================
  Hits          548      548           
  Misses        146      146           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sigrsig Sigrsig changed the title Fix forceSuggestionsAboveCursor when suggestionsPortalHost is not being used fix: forceSuggestionsAboveCursor when suggestionsPortalHost is not being used Jun 29, 2022
Copy link
Collaborator

@Sigrsig Sigrsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for contributing!

@Sigrsig Sigrsig merged commit c48b4ea into signavio:master Jun 30, 2022
Sigrsig pushed a commit that referenced this pull request Jun 30, 2022
atilafassina pushed a commit that referenced this pull request Jun 30, 2022
@github-actions github-actions bot mentioned this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants