Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plane_repeat() documentation #81

Closed
abenefield1 opened this issue Oct 12, 2023 · 4 comments · Fixed by #86
Closed

Update plane_repeat() documentation #81

abenefield1 opened this issue Oct 12, 2023 · 4 comments · Fixed by #86
Assignees
@vpnagraj

Comments

@abenefield1
Copy link
Collaborator

Currently says it can only be used on forecast, but it can also be used on observed.
dwill023 added a commit that referenced this issue Oct 12, 2023
@dwill023
Update for issue #81
a238923
@dwill023
Copy link
Collaborator

Added this to pull request #76. Should close once merged.

@dwill023 dwill023 linked a pull request Oct 12, 2023 that will close this issue
52 shiny app for planes scoring #76
Closed
@abenefield1
Copy link
Collaborator Author

plane_taper() has a typo also. in the description, "plausibility" is misspelled. Figured this could get taken care of on this branch too

@dwill023 dwill023 removed a link to a pull request Oct 23, 2023
52 shiny app for planes scoring #76
Closed
dwill023 added a commit that referenced this issue Oct 23, 2023
@dwill023
Revert "Update for issue #81"
d6a3500 
This reverts commit a238923.
@vpnagraj
Copy link
Collaborator

@dwill023 noting that you reverted the commit from the PR. i will take this one (and will run hunspell to check any other typos: https://cran.r-project.org/web/packages/hunspell/vignettes/intro.html#Check_Manual_Pages)

@vpnagraj vpnagraj assigned vpnagraj and unassigned dwill023 and abenefield1 Oct 24, 2023
@vpnagraj
Copy link
Collaborator

hah. just saw that you already started this @dwill023 on https://github.com/signaturescience/rplanes/tree/81-update-plane_repeat-documentation

ill take care of the spell checking and will open a PR when ready. stand by on any other edits to that branch please.

@vpnagraj vpnagraj linked a pull request Oct 25, 2023 that will close this issue
81 update plane repeat documentation #86
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vpnagraj vpnagraj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

81 update plane repeat documentation signaturescience/rplanes
3 participants
@vpnagraj @dwill023 @abenefield1