Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add preconfigured support for Smart Agent #8

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

jtmal-signalfx
Copy link
Contributor

No description provided.

@tsloughter-splunk
Copy link
Contributor

The issue where exporters set with the environment variable can't be external also exists for the propagators. The argument was that it is only the environment variable and you are suppose to set custom propagators through the configuration setup code. Is that possible for exporters as well? If not that may be what we want to contribute back.

Though I recall not using the environment variables causes weirdness and that is why I had to do a lot through them in the existing setup code... I'll have to look into this more Monday and can ping some people. Unless you already know if this is just not possible at this time but technically could be.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jtmal-signalfx
Copy link
Contributor Author

The issue where exporters set with the environment variable can't be external also exists for the propagators. The argument was that it is only the environment variable and you are suppose to set custom propagators through the configuration setup code. Is that possible for exporters as well? If not that may be what we want to contribute back.

Sent open-telemetry/opentelemetry-ruby#1365

@jtmal-signalfx jtmal-signalfx force-pushed the feat/smart-agent branch 2 times, most recently from 9c6e69f to 7dcf3e4 Compare August 24, 2022 15:26
@jtmal-signalfx jtmal-signalfx marked this pull request as ready for review August 24, 2022 15:30
@jtmal-signalfx jtmal-signalfx requested review from a team as code owners August 24, 2022 15:30
@theletterf
Copy link
Contributor

There's still a docs suggestion to merge

@jtmal-signalfx jtmal-signalfx dismissed theletterf’s stale review August 30, 2022 12:05

Changes included manually

@jtmal-signalfx jtmal-signalfx merged commit 399714f into main Aug 30, 2022
@jtmal-signalfx jtmal-signalfx deleted the feat/smart-agent branch August 30, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants