add railtie based RUM Rack instrumentation #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7db4c89 to
60f4a0c
Compare
|
I did the same exporter stuff as the rack test but it fails in rails_test. |
instead of creating a new exporter in RumRailsTest and RackRailsTest have EXPORTER instance created globally and reset it in the teardown method of the testcases. It may be useful to figure out in the future why creating a new exporter in each testcase was resulting in no spans making it to the exporter in the second test to run.
48aad37 to
53aace3
Compare
| class Railtie < ::Rails::Railtie | ||
| # TODO: use an explicit ordering to be after the Otel middleware | ||
| # instead of just adding it to the end of the list of middlewares | ||
| config.before_initialize do |app| |
There was a problem hiding this comment.
config.before_initialize do |app|
app.middleware.insert_before(
ActionDispatch::ServerTiming,
Splunk::Otel::Rack::RumMiddleware
)
end
the order is reversed. ActionDispatch::ServerTiming will overwrite server-timing, so we need to append after to their values.
|
Added a couple of comments, I think that documentation would be good to have, even if it's very basic, e.g. without any troubleshooting tips. |
jtmal-signalfx
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.