Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUM middleware #23

Merged
merged 10 commits into from
Jun 9, 2022
Merged

RUM middleware #23

merged 10 commits into from
Jun 9, 2022

Conversation

tsloughter-splunk
Copy link
Contributor

No description provided.

@tsloughter-splunk tsloughter-splunk requested review from a team as code owners May 17, 2022 21:03
@tsloughter-splunk tsloughter-splunk changed the title Ts/rum common RUM middleware May 17, 2022
@tsloughter-splunk
Copy link
Contributor Author

Still need to add a test for action pack and docs on using this with Rack or Rails.

@tsloughter-splunk tsloughter-splunk requested a review from a team as a code owner May 17, 2022 21:12
jtmal-signalfx
jtmal-signalfx reviewed May 27, 2022
View reviewed changes
splunk-otel.gemspec Outdated Show resolved Hide resolved
@tsloughter-splunk tsloughter-splunk mentioned this pull request Jun 7, 2022
Closed
@jtmal-signalfx
Copy link
Contributor

I think it's fine to check CORS later and merge now.

@jtmal-signalfx jtmal-signalfx merged commit 9f163c0 into main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtmal-signalfx jtmal-signalfx jtmal-signalfx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsloughter-splunk @jtmal-signalfx