Add support for GlassFish #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovencij
suggested changes
Dec 7, 2020
.../main/java/com/splunk/opentelemetry/middleware/GlassfishAttributesInstrumentationModule.java
Outdated
Show resolved
Hide resolved
vovencij
approved these changes
Dec 7, 2020
| @Override | ||
| protected WaitStrategy getWaitStrategy() { | ||
| return Wait.forLogMessage(".*app was successfully deployed.*", 1) | ||
| .withStartupTimeout(Duration.ofMinutes(15)); |
There was a problem hiding this comment.
That's a huge timeout. Does it really take this long to start?
There was a problem hiding this comment.
No, it does not. Left from local testing, will decrease separately
mateuszrzeszutek
approved these changes
Dec 7, 2020
iNikem
added a commit
that referenced
this pull request
Dec 10, 2020
* Introduce proprietary images in test matrix and convert weblogic to such. * Add support for GlassFish (#51) * Add support for GlassFish * Update Tomcat to new images as well * Format * Simplify config * Update to new images that use application with context path * Polish * Actually disable failing test for now * add maven local repository (#52) * Detect liberty version (#53) Detect WebSphere liberty version. * Update tests to play well with both proprietary and public images. * Removed separate weblogic project. * Remove matrix parts for images that are reused from opentelemetry-java-instrumentation matrix. * Remove matrix parts for images that are reused from opentelemetry-java-instrumentation matrix. Co-authored-by: Nikita Salnikov-Tarnovski <nsalnikovtarnovski@splunk.com> Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.