Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on splunk.continuousDiscovery feature gate by default #5847

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

dmitryax
Copy link
Contributor

This enables new way to discover third-party components and collect metrics from them:

  • It allows discovering services that were not available at the time of the collector startup but were started later.
  • Information about discovered services will be sent to Splunk Observability Cloud that can be found in "Discovered services" page. If you want to disable this feature and bring back the old behavior, add --feature-gates=-splunk.continuousDiscovery command line flag.

@dmitryax dmitryax force-pushed the flip-feature-gate-for-continuos-discovery branch 2 times, most recently from fcdab45 to 5b86e5f Compare January 29, 2025 17:55
@dmitryax dmitryax marked this pull request as ready for review January 29, 2025 17:55
@dmitryax dmitryax requested review from a team as code owners January 29, 2025 17:55
@dmitryax dmitryax force-pushed the flip-feature-gate-for-continuos-discovery branch from 5b86e5f to b5888d5 Compare January 29, 2025 20:45
This enables new way to discover third-party components and collect metrics from them:
  - It allows discovering services that were not available at the time of the collector startup but were started later.
  - Information about discovered services will be sent to Splunk Observability Cloud that can be found in "Discovered services" page.
If you want to disable this feature and bring back the old behavior, add `--feature-gates=-splunk.continuousDiscovery` command line flag.
@dmitryax dmitryax force-pushed the flip-feature-gate-for-continuos-discovery branch from b5888d5 to f68b8e4 Compare January 29, 2025 21:33
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, one typo nit

Co-authored-by: Antoine Toulme <atoulme@splunk.com>
@dmitryax dmitryax merged commit e0d6d05 into main Jan 30, 2025
265 of 267 checks passed
@dmitryax dmitryax deleted the flip-feature-gate-for-continuos-discovery branch January 30, 2025 00:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants