Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose internal metrics at default localhost:8888 address #5706

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

dmitryax
Copy link
Contributor

@dmitryax dmitryax commented Dec 13, 2024

Expose internal metrics at default localhost:8888 address instead of ${SPLUNK_LISTEN_INTERFACE}:8888

This can be changed in service::telemetry::metrics section:

service:
  telemetry:
    metrics:
      readers:
        - pull:
            exporter:
              prometheus:
                host: localhost
                port: 8888

This also removes a warning about deprecated service::telemetry::metrics::address.

@dmitryax dmitryax marked this pull request as ready for review December 13, 2024 03:55
@dmitryax dmitryax requested review from a team as code owners December 13, 2024 03:55
@dmitryax dmitryax force-pushed the update-service-telemetry-metrics branch from 2011cbe to 9129fee Compare December 13, 2024 03:58
Expose internal metrics at default `localhost:8888` address instead of `${SPLUNK_LISTEN_INTERFACE}:8888`

This can be changed by changing default values in `service::telemetry::metrics::section`:
```yaml
service:
  telemetry:
    metrics:
      readers:
        - pull:
            exporter:
              prometheus:
                host: localhost
                port: 8888
```
This also removes a warning about deprecated `service::telemetry::metrics::address`.
@dmitryax dmitryax force-pushed the update-service-telemetry-metrics branch from 9129fee to 8217ab8 Compare December 13, 2024 05:11
@dmitryax dmitryax requested a review from a team as a code owner December 13, 2024 05:11
@dmitryax dmitryax merged commit 0a7f444 into main Dec 13, 2024
252 checks passed
@dmitryax dmitryax deleted the update-service-telemetry-metrics branch December 13, 2024 16:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants