Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add puppet support for Node.js auto-instrumentation on Linux #4207

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Add puppet support for Node.js auto-instrumentation on Linux #4207

merged 3 commits into from
Mar 26, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 27, 2024

Description:
Add puppet support for Node.js auto-instrumentation on Linux

@atoulme atoulme requested review from a team as code owners January 27, 2024 08:17
@atoulme atoulme force-pushed the zero-config-puppet branch 9 times, most recently from 0844e07 to 881058b Compare January 28, 2024 05:49
pjanotti
pjanotti reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previos with_auto_instrumentation option should be removed.

deployments/puppet/README.md Show resolved Hide resolved
deployments/puppet/README.md Show resolved Hide resolved
@atoulme atoulme force-pushed the zero-config-puppet branch from 45d7eb5 to e9a6134 Compare March 9, 2024 00:48
jvoravong
jvoravong approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@jvoravong jvoravong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please make sure to resolve any follow up topics with other reviewers.

@hughesjj hughesjj merged commit bb47ba5 into main Mar 26, 2024
73 checks passed
@delete-merged-branch delete-merged-branch bot deleted the zero-config-puppet branch March 26, 2024 22:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jinja2 jinja2 jinja2 left review comments

@samiura samiura samiura approved these changes

@jvoravong jvoravong jvoravong approved these changes

@pjanotti pjanotti pjanotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@atoulme @pjanotti @jinja2 @jvoravong @samiura @hughesjj