Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Puppet8x support #4150

Closed
wants to merge 1 commit into from
Closed

Add Puppet8x support #4150

wants to merge 1 commit into from

Conversation

flepoutre
Copy link

@flepoutre flepoutre commented Jan 12, 2024

Description:
Adds support for Puppet 8.x

@flepoutre flepoutre requested review from a team as code owners January 12, 2024 14:06
Copy link
Contributor

github-actions bot commented Jan 12, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@atoulme
Copy link
Contributor

atoulme commented Jan 12, 2024

Thank you for this contribution, we appreciate it.
I see 2 sets of changes:

  • Changes to the way constructors or function calls are made, which are made for readability
  • Changes to how some variables are read to support Puppet 8.x

I am OK with the first set and we can look at introducing it with a simple PR with just those immediately.
For the latter set of changes, we would also want to test with Puppet 8 as an additional matrix in our tests.

@atoulme
Copy link
Contributor

atoulme commented Jan 12, 2024

Please accept the CLA per the comment above and we will take it up to add support for Puppet 8.x testing.

@flepoutre
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

srv-gh-o11y-gdi-cla added a commit to splunk/cla-agreement that referenced this pull request Jan 15, 2024
@flepoutre
Copy link
Author

Thanks for your feedback.

@pjanotti
Copy link
Contributor

Closing this PR until tests for Puppet 8 are added.

@pjanotti pjanotti closed this Jan 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants