Fix bundler gem install, specify version explicitly #4120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
reviewed
Jan 3, 2024
| @@ -974,7 +974,7 @@ puppet-release: | |||
| except: | |||
| - schedules | |||
| before_script: | |||
| - gem install bundler | |||
| - gem install bundler -v 2.4.22 | |||
There was a problem hiding this comment.
Can (or will) this version be updated automatically, or will we have some kind of reminder to update periodically?
There was a problem hiding this comment.
gem install bundler -v '<2.5' should be adequate. ruby 2.6 has been eol since 4/22 so any further investment beyond unblocking builds could include moving to ~3.1 or so as puppet support dictates.
There was a problem hiding this comment.
This very narrowly fixes the build and we need a followup. I’ll file a bug.
rmfitzpatrick
approved these changes
Jan 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/signalfx/splunk-otel-collector/actions/runs/7242168501/job/20136916554?pr=4086