Adding mysql integration tests #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiura
commented
Dec 14, 2023
•
atoulme
approved these changes
Dec 14, 2023
jvoravong
approved these changes
Dec 14, 2023
crobert-1
approved these changes
Dec 14, 2023
tests/receivers/mysql/mysql_test.go
Outdated
|
|
||
| var mysql = []testutils.Container{testutils.NewContainer().WithContext( | ||
| path.Join(".", "testdata", "server"), | ||
| ).WithName("mysql").WithExposedPorts("3306:3306").WillWaitForPorts("3306").WillWaitForLogs("X Plugin ready for connections. Bind-address:")} |
There was a problem hiding this comment.
Nit: 3306 is used a few times in this file, maybe move it to a variable?
| ENV MYSQL_ROOT_PASSWORD='testuser' | ||
|
|
||
| COPY initMySqlDB.sql /docker-entrypoint-initdb.d/ | ||
|
|
| digest_text_limit: 120 | ||
| time_limit: 24h | ||
| limit: 250 | ||
| exporters: |
There was a problem hiding this comment.
Suggested change
| exporters: | |
| exporters: |
| endpoint: "${OTLP_ENDPOINT}" | ||
| tls: | ||
| insecure: true | ||
|
|
| - instrumentation_scope: | ||
| attributes: {} | ||
| name: otelcol/mysqlreceiver | ||
| version: <ANY> |
There was a problem hiding this comment.
Suggested change
| version: <ANY> | |
| version: <VERSION_FROM_BUILD> |
tests/receivers/mysql/mysql_test.go
Outdated
| "github.com/signalfx/splunk-otel-collector/tests/testutils" | ||
| ) | ||
|
|
||
| var mysql = []testutils.Container{testutils.NewContainer().WithContext( |
There was a problem hiding this comment.
nit, until this is shared no need to make global
tests/receivers/mysql/mysql_test.go
Outdated
Comment on lines
31
to
32
| // This test ensures the collector can connect to a MySQL DB, and properly get metrics. It's not intended to | ||
| // test the receiver itself. |
There was a problem hiding this comment.
wading into semantics, these tests are partially intended to test the underlying components. Though some of the expectations we have about the reported telemetry may need to be updated (resource metric file changes), they can detect breaking changes or bugs that may have been missed upstream.
38819b6 to
8f77451
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.