Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial puppet module for linux #405

Merged
merged 2 commits into from
May 18, 2021
Merged

Initial puppet module for linux #405

merged 2 commits into from
May 18, 2021

Conversation

jeffreyc-splunk
Copy link
Contributor

@jeffreyc-splunk jeffreyc-splunk commented May 13, 2021 •
edited
Loading

Recreated PR and addressed comments from #374

  • Ported from smart agent
  • Install fluentd, plugins, and dependencies by default
  • Use agent_config.yaml and fluent.conf from the collector package by default; can be configured to use custom files
  • Add test job (lint, rake-spec, and pytest) to circleci

@jeffreyc-splunk jeffreyc-splunk force-pushed the puppet branch 7 times, most recently from ca3a3a1 to f3fa090 Compare May 17, 2021 14:32
@jeffreyc-splunk jeffreyc-splunk marked this pull request as ready for review May 17, 2021 15:50
@jeffreyc-splunk jeffreyc-splunk requested review from a team as code owners May 17, 2021 15:50
@jeffreyc-splunk
Copy link
Contributor Author

@tmorrisonsfx PTAL again at the README.md. I believe that I have addressed your feedback from #374.

@tmorrisonsfx
Copy link

@tmorrisonsfx PTAL again at the README.md. I believe that I have addressed your feedback from #374.

@jcheng-splunk Yes, LGTM.

rmfitzpatrick
rmfitzpatrick reviewed May 17, 2021
View reviewed changes
deployments/puppet/release

echo "Module was successfully built and is available in ./pkg/$(basename $expected_output)"
echo
echo "You must manually upload this file in the Puppet forge web UI by following the directions at https://puppet.com/docs/puppet/5.4/modules_publishing.html#upload-a-module-to-the-forge"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not required here but something like these may be useful in future https://github.com/voxpupuli/puppet-blacksmith https://github.com/barnumbirr/action-forge-publish

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not required here but something like these may be useful in future https://github.com/voxpupuli/puppet-blacksmith https://github.com/barnumbirr/action-forge-publish

Thanks! I'll look into it.

rmfitzpatrick
rmfitzpatrick approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@rmfitzpatrick rmfitzpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ test updated

@jeffreyc-splunk jeffreyc-splunk merged commit e35a087 into signalfx:main May 18, 2021
@jeffreyc-splunk jeffreyc-splunk deleted the puppet branch May 18, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmfitzpatrick rmfitzpatrick rmfitzpatrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffreyc-splunk @tmorrisonsfx @rmfitzpatrick