Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chef: Support Node.js zero config for Linux #4020

Merged
merged 1 commit into from
Dec 18, 2023
Merged

chef: Support Node.js zero config for Linux #4020

merged 1 commit into from
Dec 18, 2023

Conversation

jeffreyc-splunk
Copy link
Contributor

@jeffreyc-splunk jeffreyc-splunk commented Dec 4, 2023 •
edited
Loading

  • Add initial Node.js zero config for Linux support with chef (installed and activated by default if npm is found)
  • Requires Node.js and npm to be installed/managed separately
  • Update tests to install node with the nodejs cookbook, verify installation of splunk-otel-js, and verify config files for both preload and systemd methods

@jeffreyc-splunk jeffreyc-splunk changed the title chef: Support Node.js zero config chef: Support Node.js zero config for Linux Dec 5, 2023
@jeffreyc-splunk jeffreyc-splunk force-pushed the chef-node-zc branch 12 times, most recently from d5c597a to 8513b56 Compare December 12, 2023 20:01
@jeffreyc-splunk jeffreyc-splunk marked this pull request as ready for review December 12, 2023 20:45
@jeffreyc-splunk jeffreyc-splunk requested review from a team as code owners December 12, 2023 20:45
hughesjj
hughesjj approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@hughesjj hughesjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the 0.0.0.0 is correct I think it's ready to ship. Could be cleaner but can always take care of that in a subsequent review, none of the nits block shipment (hence, nit's and not blocker's)

.github/workflows/chef-test.yml Show resolved Hide resolved
deployments/chef/kitchen.yml Show resolved Hide resolved
deployments/chef/kitchen.yml Show resolved Hide resolved
deployments/chef/kitchen.yml Show resolved Hide resolved
deployments/chef/kitchen.yml Show resolved Hide resolved
deployments/chef/kitchen.yml Show resolved Hide resolved
@jeffreyc-splunk
Copy link
Contributor Author

If the 0.0.0.0 is correct I think it's ready to ship. Could be cleaner but can always take care of that in a subsequent review, none of the nits block shipment (hence, nit's and not blocker's)

The kitchen.yml file and values defined within are only for tests.

@jvoravong jvoravong merged commit 4b2c550 into main Dec 18, 2023
27 checks passed
@delete-merged-branch delete-merged-branch bot deleted the chef-node-zc branch December 18, 2023 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jvoravong jvoravong jvoravong approved these changes

@hughesjj hughesjj hughesjj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffreyc-splunk @hughesjj @jvoravong