-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgresql discovery config - add OTel native receiver #3957
Postgresql discovery config - add OTel native receiver #3957
Conversation
fmt fmt config tweak and bundle
"--set", "splunk.discovery.receivers.postgresql.config.password=otelp", | ||
"--set", "splunk.discovery.receivers.postgresql.config.tls::insecure=true", | ||
//Disabling postgresql.backends metric that doesn't dependably show up in metrics during testing | ||
"--set", "splunk.discovery.receivers.postgresql.config.metrics::postgresql.backends::enabled=false", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was strange. During testing I'd have a 50/50 shot of this postgresql.backends
metric showing up or not when pulling metrics for comparison.
Tried longer startup times and different methods of generating connections to try to get this metric to consistently show up but couldn't find any real rhyme or reason.
Open to ideas if it is imperative we have this enabled for testing.
internal/confmapprovider/discovery/bundle/bundle.d/receivers/postgresql.discovery.yaml.tmpl
Show resolved
Hide resolved
…testusername-splunk/splunk-otel-collector into postgresql-discovery-config
Should be all set to go unless there are more requested changes. |
internal/confmapprovider/discovery/bundle/bundle.d/receivers/postgresql.discovery.yaml.tmpl
Outdated
Show resolved
Hide resolved
It'd be helpful to add an entry to https://github.com/signalfx/splunk-otel-collector/blob/main/cmd/otelcol/config/collector/config.d.linux/properties.discovery.yaml.example (I hope to automate this w/ the bundlegen process in the future) |
…ostgresql.discovery.yaml.tmpl Co-authored-by: Ryan Fitzpatrick <10867373+rmfitzpatrick@users.noreply.github.com>
Do you want me to remove the |
I'd just set the enabled to false instead of removing so that the file can be a quick place to look for the bundled components. I plan on using the tooling updates in #4066 as a base to automatically generate the example property content w/ that in mind, but if you'd prefer they not be included instead it'd be helpful to know why. |
I think this is just a flakey test issue?
|
@greatestusername-splunk sorry, I've shifted things from under you. Do you mind ~rebasing and adding the receiver to the new https://github.com/signalfx/splunk-otel-collector/blob/main/internal/confmapprovider/discovery/bundle/components.go#L33 before running |
@@ -16,4 +16,6 @@ splunk.discovery: | |||
smartagent/collectd/nginx: | |||
enabled: true | |||
smartagent/postgresql: | |||
enabled: false | |||
postgresql: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, alpha ordering plz
no prob! Should be all set |
- instrumentation_scope: | ||
attributes: {} | ||
name: otelcol/postgresqlreceiver | ||
version: <ANY> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version: <ANY> | |
version: <VERSION_FROM_BUILD> |
nit, though there's a handful of other instances as well
Mind adding a breaking change changelog item and update the discovery readme to include the component? https://github.com/signalfx/splunk-otel-collector/tree/main/internal/confmapprovider/discovery#discovery-mode I'll look into automating a table along w/ the example properties automation work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm w/ final requests.
In and ready. 😄 |
Description: Changes the bundled test and discovery configs for postgresql to the native OTEL receiver. Disables old smartagent postgresql discovery
Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>
Testing: Bundled tests updated