Bump golang.org/x/tools from 0.14.0 to 0.15.0 in /internal/tools #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
edit: may be transient or resulting from undetermined behavior since it's cleared on rebased attempt. |
2fb4432 to
bf90e7c
Compare
|
Running tests again to confirm no real issue |
|
@dependabot recreate |
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.14.0 to 0.15.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.14.0...v0.15.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
bf90e7c to
b748797
Compare
|
Lint hit a panic in |
|
Yep, still hitting it intermittently (sometimes it passes): Notice it will fail with different package being the target, but always within |
|
I believe Ryan's comment is correct, the panics are being hit in updated dependencies. I point to dependencies as the cause because there's no consistency in our repo where it's being hit. This is not essential to update at this time, we'll wait until it's fixed. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps golang.org/x/tools from 0.14.0 to 0.15.0.
Release notes
Sourced from golang.org/x/tools's releases.
Commits
729e159go.mod: update golang.org/x dependencies38ed81agopls/internal/regtest/marker: porting extract testsbbf8380gopls/internal/regtest/marker: use golden diffs for suggested fixes51df92bgo/ssa: two minor cleanupse7fb31ainternal/cmd/deadcode: rename -format to -fc538b4einternal/cmd/deadcode: add -whylive=function flagb753e58internal/lsp/helper: fix misspelled "Code generated" comment2638d66internal/cmd/deadcode: omit package/func keywords in default output118c362gopls/internal/lsp/source: fix signatureHelp with pointer receivers4124316gopls/internal/lsp/cache: remove baseCtx from the ViewDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)