Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "TARGET_ENV: velocity" for msi signing job #3878

Closed
wants to merge 1 commit into from

Conversation

jeffreyc-splunk
Copy link
Contributor

Without this var, the "signed" MSI artifact is corrupted/uninstallable.

@jeffreyc-splunk jeffreyc-splunk marked this pull request as ready for review November 1, 2023 14:52
@jeffreyc-splunk jeffreyc-splunk requested review from a team as code owners November 1, 2023 14:52
@jeffreyc-splunk jeffreyc-splunk marked this pull request as draft November 1, 2023 15:24
@jeffreyc-splunk
Copy link
Contributor Author

Signing service has been updated. Not required, for now.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
@jeffreyc-splunk jeffreyc-splunk deleted the fix-msi-signing branch November 8, 2023 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant