Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update breaking changes for installer modules #3853

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Update breaking changes for installer modules #3853

merged 1 commit into from
Oct 30, 2023

Conversation

jeffreyc-splunk
Copy link
Contributor

No description provided.

@jeffreyc-splunk jeffreyc-splunk marked this pull request as ready for review October 27, 2023 21:19
@jeffreyc-splunk jeffreyc-splunk requested review from a team as code owners October 27, 2023 21:19
@aunshc
Copy link
Contributor

aunshc commented Oct 27, 2023

Thanks Jeff, LGTM!

@aunshc
Copy link
Contributor

aunshc commented Oct 30, 2023

Once https://github.com/signalfx/splunk-otel-collector/pull/3851/files is merged, I suggest adding a note about the deprecated installer script options in the changelog as well.

@jeffreyc-splunk
Copy link
Contributor Author

Once https://github.com/signalfx/splunk-otel-collector/pull/3851/files is merged, I suggest adding a note about the deprecated installer script options in the changelog as well.

See https://github.com/signalfx/splunk-otel-collector/pull/3851/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed

@jeffreyc-splunk jeffreyc-splunk merged commit f14aeb3 into main Oct 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the jeffreyc-splunk-patch-2 branch October 30, 2023 14:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atoulme atoulme atoulme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffreyc-splunk @aunshc @atoulme