Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark old instrumentation options as deprecated in installer script usage #3851

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Mark old instrumentation options as deprecated in installer script usage #3851

merged 2 commits into from
Oct 30, 2023

Conversation

jeffreyc-splunk
Copy link
Contributor

@jeffreyc-splunk jeffreyc-splunk commented Oct 27, 2023 •
edited
Loading

Since the new libsplunk.so will no longer generate the service name (the instrumentation agents will handle it) or the splunk.linux-autoinstr.executions metric, the --[no-]generate-service-name and --[enable|disable]-telemetry options will no longer be applicable.

@jeffreyc-splunk jeffreyc-splunk marked this pull request as ready for review October 27, 2023 21:19
@jeffreyc-splunk jeffreyc-splunk requested review from a team as code owners October 27, 2023 21:19
@jeffreyc-splunk jeffreyc-splunk requested a review from a team as a code owner October 30, 2023 14:12
@jeffreyc-splunk jeffreyc-splunk merged commit 500d0ce into main Oct 30, 2023
92 checks passed
@delete-merged-branch delete-merged-branch bot deleted the jeffreyc-splunk-patch-1 branch October 30, 2023 21:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atoulme atoulme atoulme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffreyc-splunk @atoulme