Simple lint fixes to help support newer version of github.com/golangci/golangci-lint in /internal/tools #3843

jvoravong · 2023-10-24T23:00:46Z

Description:

First PR for the easy lint updates to support bumping the golangci-lint version.
A second PR will come out with less easy updates that will be needed which will involve updating prometheus exporter code.

…i/golangci-lint in /internal/tools

internal/signalfx-agent/pkg/utils/filter/filter.go

atoulme

LGTM

internal/signalfx-agent/pkg/core/dpfilters/filter.go

internal/signalfx-agent/pkg/core/propfilters/filter_test.go

internal/signalfx-agent/pkg/monitors/subproc/core.go

Co-authored-by: Antoine Toulme <antoine@toulme.name>

rmfitzpatrick · 2023-10-25T13:47:54Z

Mind updating the dep w/ these changes?

jvoravong · 2023-10-25T14:38:00Z

Reverted "Bump github.com/golangci/golangci-lint in /internal/tools Revert "Bump github.com/golangci/golangci-lint in /internal/tools #3842" as part of Revert "Bump github.com/golangci/golangci-lint in /internal/tools #3842 yesterday.
Still need to get a second PR out with less easy updates that will be needed for upgrading the lint dependency.

Simple lint fixes to help support newer version of github.com/golangc…

db32e9b

…i/golangci-lint in /internal/tools

jvoravong requested review from a team as code owners October 24, 2023 23:00

dmitryax reviewed Oct 25, 2023

View reviewed changes

internal/signalfx-agent/pkg/utils/filter/filter.go Outdated Show resolved Hide resolved

atoulme reviewed Oct 25, 2023

View reviewed changes

internal/signalfx-agent/pkg/utils/filter/filter.go Outdated Show resolved Hide resolved

atoulme approved these changes Oct 25, 2023

View reviewed changes

pjanotti reviewed Oct 25, 2023

View reviewed changes

internal/signalfx-agent/pkg/core/dpfilters/filter.go Outdated Show resolved Hide resolved

pjanotti reviewed Oct 25, 2023

View reviewed changes

internal/signalfx-agent/pkg/core/propfilters/filter_test.go Show resolved Hide resolved

pjanotti approved these changes Oct 25, 2023

View reviewed changes

internal/signalfx-agent/pkg/monitors/subproc/core.go Outdated Show resolved Hide resolved

jvoravong and others added 2 commits October 24, 2023 22:01

Update internal/signalfx-agent/pkg/utils/filter/filter.go

c55f2e0

Co-authored-by: Antoine Toulme <antoine@toulme.name>

Shorten parameter names in interface methods

599edd0

rmfitzpatrick approved these changes Oct 25, 2023

View reviewed changes

jvoravong merged commit dc3794a into signalfx:main Oct 25, 2023
44 checks passed

github-actions bot locked and limited conversation to collaborators Oct 25, 2023

Provide feedback