Add comments for debug and logging exporter #3768
Conversation
Co-authored-by: Ryan Fitzpatrick <10867373+rmfitzpatrick@users.noreply.github.com>
Co-authored-by: Ryan Fitzpatrick <10867373+rmfitzpatrick@users.noreply.github.com>
|
@rmfitzpatrick I only edited comments and now a couple integration tests are failing? How so? |
The test failures are expected since the agent config has been changed. This is what the test is for since changes to this config are meaningful for users. You can update the expected value to reflect the contents at the path detailed in the failure. |
Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>
|
We haven't reverted the other PR yet. What's the decision here, @atoulme ? |
If you update the |
| @@ -156,7 +156,8 @@ exporters: | |||
| endpoint: "${SPLUNK_GATEWAY_URL}:4317" | |||
| tls: | |||
| insecure: true | |||
| # Debug | |||
| # This component has been deprecated by the "debug" exporter, | |||
There was a problem hiding this comment.
This comment only makes sense in the context of a logging exporter.
|
@rmfitzpatrick @jeffreyc-splunk TBH, I'm a bit confused right now as to what I should change for this to go through. Ryan, you seem to suggest a partial revert of some config files: could you apply the relevant code suggestions? I feel like I'm cutting red wire from a detonator right now... :-) |
If we're not reverting the previous changes, I think the test failures would be resolved by rebasing the branch with main. |
|
I would like us to be forward looking and adopt the latest, document that previous versions use the previous approach. We can discuss in team meeting and weigh pros and cons a bit more. |
Follows #3755