Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added kafkametricsreceiver #316

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Conversation

harnitsignalfx
Copy link

Adding the kafkametricsreceiver which should allow us to ingest kafka consumer lag

@harnitsignalfx harnitsignalfx force-pushed the metricsreceiver branch 2 times, most recently from c9b1996 to 669ffde Compare April 21, 2021 22:36
@harnitsignalfx
Copy link
Author

Any ideas on how I can fix the failing test?

@jrcamp
Copy link
Contributor

jrcamp commented Apr 22, 2021

@harnitsignalfx
Copy link
Author

Hmm, it should be there in the files I've committed. No dice.

@jrcamp
Copy link
Contributor

jrcamp commented Apr 22, 2021

Oh it's because the actual receiver name is kafkametrics not kafkametricsreceiver :-P

@harnitsignalfx
Copy link
Author

Oh, let me try that, thanks Jay

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #316 (2936bbc) into main (80d32ed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   79.10%   79.11%           
=======================================
  Files          30       30           
  Lines        2240     2241    +1     
=======================================
+ Hits         1772     1773    +1     
  Misses        423      423           
  Partials       45       45           
Impacted Files Coverage Δ
internal/components/components.go 84.21% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d32ed...2936bbc. Read the comment docs.

docs/components.md Outdated Show resolved Hide resolved
@harnitsignalfx harnitsignalfx force-pushed the metricsreceiver branch 2 times, most recently from 3310d88 to 6f87ae8 Compare April 22, 2021 17:49
@jrcamp jrcamp merged commit c663ba4 into signalfx:main Apr 22, 2021
@harnitsignalfx harnitsignalfx deleted the metricsreceiver branch April 22, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants