-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added kafkametricsreceiver #316
Conversation
c9b1996
to
669ffde
Compare
Any ideas on how I can fix the failing test? |
Ah needs to be added to this list https://github.com/signalfx/splunk-otel-collector/blob/main/internal/components/components_test.go#L42 |
Hmm, it should be there in the files I've committed. No dice. |
Oh it's because the actual receiver name is |
Oh, let me try that, thanks Jay |
669ffde
to
29931d1
Compare
Codecov Report
@@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 79.10% 79.11%
=======================================
Files 30 30
Lines 2240 2241 +1
=======================================
+ Hits 1772 1773 +1
Misses 423 423
Partials 45 45
Continue to review full report at Codecov.
|
3310d88
to
6f87ae8
Compare
6f87ae8
to
2936bbc
Compare
Adding the kafkametricsreceiver which should allow us to ingest kafka consumer lag