docker-otelcol circleci job and Makefile updates #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de0c032 to
1521ce7
Compare
1521ce7 to
6018356
Compare
Codecov Report
@@ Coverage Diff @@
## main #261 +/- ##
=======================================
Coverage 86.83% 86.83%
=======================================
Files 20 20
Lines 1481 1481
=======================================
Hits 1286 1286
Misses 160 160
Partials 35 35 Continue to review full report at Codecov.
|
rmfitzpatrick
approved these changes
Apr 12, 2021
6018356 to
a8a30c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-otelcoljob to build and run the image before publishingmsimake targetSKIP_COMPILEMakefile var so that we can use the make targets to build the deb, rpm, msi, and docker image in circleci without recompiling the otelcol binaries