Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove smartagent/signalfx-forwarder from metrics pipeline, signalfxreceiver should be used #2574

Closed
wants to merge 1 commit into from
Closed

Remove smartagent/signalfx-forwarder from metrics pipeline, signalfxreceiver should be used #2574

wants to merge 1 commit into from

Conversation

bogdandrutu
Copy link
Contributor

No description provided.

@bogdandrutu
Remove smartagent/signalfx-forwarder from metrics pipeline, signalfxr…
bc1b195 
…eceiver should be used

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested review from a team as code owners February 16, 2023 21:14
@bogdandrutu
Copy link
Contributor Author

@flands maybe you know the reason #218 (comment). But here are the problems:

  • Same formats are fully supported in the signalfx receiver, so confusing users between which to use.
  • signalfx-forwarder does not passthrough the token.

dmitryax
dmitryax reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this change. The only problem is that now users cannot migrate from smart-agent to collector without migrating their old instrumentations. Maybe we add a deprecation warning first stating the limitation of the receiver?

@bogdandrutu
Copy link
Contributor Author

I'm good with this change. The only problem is that now users cannot migrate from smart-agent to collector without migrating their old instrumentations. Maybe we add a deprecation warning first stating the limitation of the receiver?

Why? Can you clarify?

@dmitryax
Copy link
Contributor

dmitryax commented Feb 17, 2023 •
edited
Loading

I mean, currently, users can replace signalfx-agent with the collector on the default config, and all the instrumentation will continue working. After this change, they need to either change the instrumentations to send to the new port before the switching from smart-agent (data loss expected) or migrate from agent to the collector with a manually added smartagent/signalfx-forwarder receiver in the config. I'm good with the second option, but we need to document this step in the migration doc.

Another option would be to add a deprecation warning log message to the smartagent/signalfx-forwarder mentioning its limitations and suggesting to use new receivers until we fully deprecate the smart agent

@atoulme
Copy link
Contributor

atoulme commented May 19, 2023

I would be in favor that we close this PR and instead start with a warning message and a deprecation schedule for the signalfx-forwarder. We will work the kinks. If no one objects to this course of action in the next 30 days, I will close this PR.

@dmitryax
Copy link
Contributor

I would be in favor that we close this PR and instead start with a warning message and a deprecation schedule for the signalfx-forwarder. We will work the kinks. If no one objects to this course of action in the next 30 days, I will close this PR.

Sounds good to me

@atoulme atoulme closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdandrutu @dmitryax @atoulme